Skip to content

Conversation

jeffective
Copy link
Contributor

@jeffective jeffective commented Jul 10, 2025

Does not fully close #24361 (this is only a first, simple change set)

Summary:

  • where the type of the operands allows, change expectEqual(x, y) to expect(x == y) for files in test/behavior/**
# without these changes (master branch)
$ git grep expectEqual test/behavior | wc -l
1028

# with these changes
$ git grep expectEqual test/behavior | wc -l
348

My editor was configured to re-order imports on save. Hope that isn't a huge issue.

Verification evidence:

  • the CI should pass, no new tests are introduced, only changes to existing tests

@jeffective jeffective force-pushed the 24361-reduce-expect-equal-behavior-tests branch from 2611cd9 to 86653d7 Compare July 12, 2025 21:01
@jeffective jeffective marked this pull request as ready for review July 12, 2025 21:30
@jeffective
Copy link
Contributor Author

requesting review from @alexrp

@jeffective jeffective force-pushed the 24361-reduce-expect-equal-behavior-tests branch from 86653d7 to 4ac97ea Compare July 18, 2025 05:49
@jeffective
Copy link
Contributor Author

rebased and fixed merge conflict in test/behavior/asm.zig

@jeffective jeffective force-pushed the 24361-reduce-expect-equal-behavior-tests branch from 4ac97ea to c2bf3a2 Compare August 6, 2025 04:35
@jeffective jeffective force-pushed the 24361-reduce-expect-equal-behavior-tests branch from c2bf3a2 to 6f5299a Compare August 6, 2025 04:37
@jeffective
Copy link
Contributor Author

rebased to fix merge conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behavior tests should avoid expectEqual and friends
2 participants